Fix error message from FindDotNetCliPackage task #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garath
reviewed
Dec 1, 2020
| { | ||
| var extension = Runtime.StartsWith("win") ? "zip" : "tar.gz"; | ||
| if (PackageType == "sdk") | ||
| catch (HttpRequestException ex) when (ex.Message.Contains("404 (Not Found)")) // 404 means that we successfully hit the server, and it returned 404. This cannot be a network hick-up |
There was a problem hiding this comment.
Suggested change
| catch (HttpRequestException ex) when (ex.Message.Contains("404 (Not Found)")) // 404 means that we successfully hit the server, and it returned 404. This cannot be a network hick-up | |
| catch (HttpRequestException ex) when (ex.Message.Contains("404 (Not Found)")) // 404 means that we successfully hit the server, and it returned 404. This cannot be a network hiccup |
ChadNedzlek
requested changes
Dec 1, 2020
| { | ||
| var extension = Runtime.StartsWith("win") ? "zip" : "tar.gz"; | ||
| if (PackageType == "sdk") | ||
| catch (HttpRequestException ex) when (ex.Message.Contains("404 (Not Found)")) // 404 means that we successfully hit the server, and it returned 404. This cannot be a network hick-up |
There was a problem hiding this comment.
I would REALLY rather we check the result code on line 59, rather than parse the error message. Usually it's a pain to do that, so the catch is ok... but it's just 2 lines higher, and avoid the message parsing.
ChadNedzlek
approved these changes
Dec 1, 2020
|
Hello @alexperovich! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/core-eng/issues/11538
With this change issues like dotnet/runtime#44541 will now be much more clear.